Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and refactoring #20

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Fixes and refactoring #20

merged 5 commits into from
Jun 8, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jun 4, 2020

Some fixes and refactoring that came about while working on #14

elia added 5 commits June 4, 2020 13:27
@elia
Whitespace fix
b997477
@elia
Fix Gateway header spelling
1390b82
@elia
Delegate the client creation to the payment method
d68e689
@elia
Refactor the wizard controller
c1111d0 
This makes the controller use the classic rails patter of .new(*_params)
followed by a call to #save.
@elia
Only pass the necessary values to requests
90710dd 
Being more precise by using kwargs improves the debugging experience.
@elia elia added the chore Needs to be done, for necessity or for the well-being of the project, not related to a feature label Jun 4, 2020
@elia elia self-assigned this Jun 4, 2020
@seand7565
Copy link
Contributor

Brilliant work, thanks! I've never seen this syntax before: (auth_code:, nonce:), that's really cool. It all looks good to me! 👍

@elia elia requested a review from seand7565 June 4, 2020 21:38
@seand7565 seand7565 merged commit 40e71c0 into master Jun 8, 2020
@seand7565 seand7565 deleted the elia/fixes-and-refactoring branch June 8, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seand7565 seand7565 seand7565 approved these changes

Assignees

@elia elia

Labels
chore Needs to be done, for necessity or for the well-being of the project, not related to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @seand7565